search

everypolitician / scraper_test

Data-driven scraper tests for Scraped
0 stars 0 forks source link

Don't include "yml" in the cassette name #28

Open chrismytton opened 6 years ago

chrismytton commented 6 years ago

The cassettes that are created currently have names like beverley-lynette-abrahams_yml.yml. Having "yml" in the cassette name as well as the extension doesn't seem quite right.

It looks like we need to change this bit of code to strip the extension off the filename:

https://github.com/everypolitician/scraper_test/blob/9b4326c1e04ea7c8caf368d99bb5ac3711726199/lib/scraper_test.rb#L34

chrismytton commented 6 years ago

See https://github.com/everypolitician-scrapers/south-africa-national-assembly/pull/8 for an example of this problem in action.