everypolitician / scraper_test

Data-driven scraper tests for Scraped
0 stars 0 forks source link

Change the name of the default rake task #7

Closed chrismytton closed 7 years ago

chrismytton commented 7 years ago

Problem

The rake task currently defaults to being called :test, but this conflicts with Rake::TestTask.

Proposed solution

Change the name of the rake task this library produces. I think calling it :scraper_test would probably be sensible.

tmtmtmtm commented 7 years ago

Maybe :test_data (or :data_test), to emphasise that it's running the data-driven tests?

chrismytton commented 7 years ago

Ah yep, I like :test_data. I think perhaps it would be more "standard" (FSVO) to call it test:data (with a : instead of an _)?

tmtmtmtm commented 7 years ago

Works for me!