search

everypolitician / scraper_test

Data-driven scraper tests for Scraped
0 stars 0 forks source link

Rename rake task #8

Closed chrismytton closed 7 years ago

chrismytton commented 7 years ago

This changes the name of the rake task that ships with this library from test to test:data. This will prevent it from conflicting with rake's own test task.

Fixes #7

chrismytton commented 7 years ago

it seems we haven't made master a protected branch in this repo

Have made master protected now.

and also that there are no automated tests at all running against it…

I though we'd agreed that having this running in 100s of scraper was enough of a test 😉 But yes, it would be good to have some basic automated tests, e.g. that it creates a test task with the correct name, etc to give us a bit more confidence when merging.

tmtmtmtm commented 7 years ago

having this running in 100s of scraper was enough of a test

Yep, I was thinking more here at the level of even having rubocop run against it…