search

everypolitician / viewer-sinatra

Sinatra app for (pre)viewing EveryPolitician website dynamically
http://everypolitician.org/
5 stars 5 forks source link

Fix Travis build #15634

Closed henare closed 6 years ago

henare commented 6 years ago

What does this do?

Gets Travis building master successfully again.

Why was this needed?

master cannot currently be built on Travis. We need successful builds to be able to continue to make changes.

Relevant Issue(s)

N/A

Implementation notes

Two problems were preventing the build from working.

Travis seems to now create a ~/bin folder so the scripts/install_tidy.sh script was failing. 1500da4 fixes this by not failing if the directory already exists.

Two gems had new security advisories so rake bundle:audit was failing. 87884b8 and 069ff9a fix this by updating the two gems.

Screenshots

N/A

Notes to Reviewer

N/A

Notes to Merger

N/A

henare commented 6 years ago

(NB: changes like 1500da4 would generally be better with a bit more explanation in the commit message)

@tmtmtmtm Thanks for reviewing and merging, and thanks for pulling me up on this :+1: