search

everypolitician / viewer-sinatra

Sinatra app for (pre)viewing EveryPolitician website dynamically
http://everypolitician.org/
5 stars 5 forks source link

Party names on term pages should activate filter #15656

Open wrightmartin opened 8 years ago

wrightmartin commented 8 years ago

http://everypolitician.org/uk/commons/term-table/56.html

I expected that's what it did, but it didn't

tmtmtmtm commented 8 years ago

Yeah, it's certainly planned that that will happen at some point, but it's non-trivial, as the filter is currently just a 'does this text appear anywhere on this card', and something like this would need to be a much more explicit check for the party (to make sure selecting "AL" works somewhere like http://everypolitician.org/germany/bundestag/term-table/11.html)

Patches welcome :)

tmtmtmtm commented 8 years ago

@wrightmartin why did you expect that clicking on a party would be a filter (on the current page), rather than a link (to a distinct Party page)?

wrightmartin commented 8 years ago

@tmtmtmtm I'm thinking about it, and I can't say. Considering those party names are so far away from the members, it would be difficult to show the user that something is changing way down the page.

If I were doing this ticket and we were going down the 'filter on this page' route then I'd have to consider adjusting the design to move them closer.

Otherwise a separate page would be fine