search

everypolitician / viewer-sinatra

Sinatra app for (pre)viewing EveryPolitician website dynamically
http://everypolitician.org/
5 stars 5 forks source link

New Homepage: Selecting a country should do something #307

Closed tmtmtmtm closed 9 years ago

tmtmtmtm commented 9 years ago

Either go to the relevant country homepage, or explain that we don't have data yet (and how to help)

zarino commented 9 years ago

I was imagining that the autocomplete would just always send the user to a page like everypolitician.com/country/cg (using the country's 2-letter ISO code or something) and then that page would either show all the data for that country, or show a message about not having any data and how you can help.

tmtmtmtm commented 9 years ago

The current convention is to just have them at /country-name, rather than /country/code. I think it's better to have the full name, just for nicer URLs generally, and presumably also for SEO stuff. But if we're going to change the URL structure now is definitely the time to do so.

I've opened #358 to handle the case of going to a page for a country that doesn't exist yet, so if you're doing anything with this, feel free to just assume that that will work.

tmtmtmtm commented 9 years ago

358 is now live.