Dont allow accidental webhook deletion

everypolitician / webhook-manager

Notifies other apps whenever EveryPolitician data changes, in style of GitHub's webhooks

https://everypolitician-app-manager.herokuapp.com/

1 stars 2 forks source link

Dont allow accidental webhook deletion #61

Closed chrismytton closed 8 years ago

chrismytton commented 8 years ago

Because of invalid nested forms, we had a scenario where hitting 'enter' with a field form focussed would accidentally trigger a deletion of the webhook.

Here we remove those nested forms in favour of using Rails' unobtrusive javascript (UJS) data- attributes.

tmtmtmtm commented 8 years ago

The description here was a little too obscure, so I rewrote it slightly based on the commit messages. If it's not accurate, feel free to tweak it some more!

chrismytton commented 8 years ago

:+1: