search

everypolitician / webhook-manager

Notifies other apps whenever EveryPolitician data changes, in style of GitHub's webhooks
https://everypolitician-app-manager.herokuapp.com/
1 stars 2 forks source link

Use GitHub's raw url directly in webhook body #65

Closed chrismytton closed 8 years ago

chrismytton commented 8 years ago

RawGit has sadly been down a couple of times recently. To avoid potential problems with it this switches to using a regular GitHub raw url in the payload.

chrismytton commented 8 years ago

I’ve used the canonical https://github.com/everypolitician/everypolitician-data/raw/master/countries.json form of raw url which will redirect to https://raw.githubusercontent.com/everypolitician/everypolitician-data/master/countries.json.

This is a slightly backwards incompatible change because the previous rawgit url returned a 200 whereas this one will return a 302. I think this should be fine, but am happy to be persuaded otherwise.

tmtmtmtm commented 8 years ago

@chrismytton we should either merge this or discard it. I'm not sure I understand the issues well enough to decide which…

chrismytton commented 8 years ago

RawGit hasn't gone down since I opened this, AFAIK. It's also a breaking change for existing webhook consumers who might be expecting the url to have the correct content type. So closing for now, we can revisit this later if it turns out to be needed.