everypolitician / webhook-manager

Notifies other apps whenever EveryPolitician data changes, in style of GitHub's webhooks
https://everypolitician-app-manager.herokuapp.com/
1 stars 2 forks source link

Handle GitHub accounts with no `name` field #68

Closed chrismytton closed 8 years ago

chrismytton commented 8 years ago

Problem

If a user tries to "Sign in with GitHub" and their GitHub account doesn't have a name attached to it then the account creation fails with a "Sequel::NotNullConstraintViolation: PG::NotNullViolation: ERROR: null value in column "name" violates not-null constraint" error.

Proposed solution

Don't require/expect GitHub accounts to have a name.

Acceptance criteria

Signing into the webhook manager using a GitHub account with no name doesn't produce any errors.

Related links