Check for blank webhook names

[davewhiteland]

We're trapping empty names on creation, but if you subsequently edit the entry and remove the name, blammo Internal Server Error.

Screenshot for morale-boost showing we're capturing this OK on creation which is why I had to edit it to hit the error:

• log in
• create webhook (you have to give it a name)
• view list of existing webhooks
• click on pen icon to edit it
• delete name in text field
• click Update webhook
• error

Screenshot shows this error being safely trapped at webhook-creation time (so this isn't the error, but presumably the remedy will look like this when an attempt to update a webhook with a blank name is made):

[chrismytton]

I think the real issue is do we actually want or need the webhooks to have names? This is another hangover from ye olde times when this was for creating apps, rather than webhooks.

I say we just remove the name field from webhooks altogether.

[chrismytton]

Hmm, on the other hand the name field currently acts as a "note" field. If we displayed it alongside the url then it might be a bit easier to comprehend than just a big list of urls.

[chrismytton]

Worth noting that this error also occurs if you try and delete the webhook's url, so whether we keep the name field or not, this error needs fixing.

[davewhiteland]

Yeah I think the name is handy, because we can't know that the URL of the app is expressive enough to usefully distinguish to the-owner-of-a-github-account (might not be a single individual?) which/why the webhook was created, or even what the app is doing.

Since it's already there, I vote for keeping it.