Closed halfempty closed 10 years ago
A note on this, which occurs to me as I go through tagging... It would be super useful to set up a minimum number of images in a given tag for it to show up in the list - otherwise, there's going to be a lot of nearly empty tags to click on, not so interesting for a user, I think. Just picking an arbitrary number here, but 5 sounds about right to me.
Image tag categories now display as gallery pages. For instance:
Aw, hell yeah. Lookin' good.
Incidentally, the images in the slideshow are showing up at thumbnail sized for me...
@ncalcott Image size corrected.
@ncalcott @KyleETC @gehalber
Some progress on this one...
http://www.nicholascalcott.com/index/
As you can see, the styles aren't in yet but I wanted to get some feedback on something. The mockup shows three levels of nesting. That is:
At this stage, because we're hiding tags that have less than five items, we don't have enough images tagged at the various levels to really pull this off. That is, we have no level-threes with five or more images.
It would be really helpful to have at least one of those well-stocked third-levels in the system, to do the programing with.
Also, I've begun to build this as a separate page, rather than as an overlay on the other pages. This way'll be much easier to pull off. Let me know if this is cool, or if you'd like it to be an overlay.
@halfempty Actually, the stylesheet for this page doesn't seem to be loading... And I'll try and get to tagging more stuff - sorry, I've been totally slammed the last few days. Unfortunately, I'm off this weekend too, so I won't get to it until Monday - I'll create a fake one for the purposes of dev for the moment. Also, I should mention that I actually would prefer that that top-level image tag actually be a non working hyperlink. That is to say, I'm not sure how interesting or useful it is to be able to see things that have been tagged something within the category "Image properties", for example...
Sorry, I should be more precise - the stylesheet is loading, it's the styling for the tags which aren't. Right now it's just showing up as the default nested unordered list...
OK, so I've added "Temp Tag" and "Another Temp Tag" as child-tags of "Black and White". Right now they're showing up as second-level tags for some reason...
@ncalcott @KyleETC @gehalber
More progress... http://www.nicholascalcott.com/index/
Three columns doesn't turn out to be super simple. The CSS "columns" property doesn't work with content of this kind (technical explination available upon request).
So this would be a good opportunity to let me know if you would, indeed, like this in three columns? Or maybe you have other visual tweaks you'd like to make before I go further? Let me know either way!
Looking good! I'm trying to push the tagging in my free moments, so you should have more to play with in the next couple days...
Two tweaks: Let's add a little left and right padding to each cell. I've reproduced this in the document for "Image Properties" and "Film Type" to show you what I mean.
Second, There should be more line height. In the indesign doc I have 22px.
I do think the three columns, or maybe even 4 columns, is important. Is that going to be difficult to do?
@gehalber Made some progress here. Was pleasantly surprised that I was able to get columns to work with CSS! The tages in the columns aren't quite lining up along the top, haven't yet figured out why...
So, I am nearing the end of my tagging - there's a few more left to do, and I'll keep adding tags as I add images, but I'm afraid I've backed off the amount of tags that I was originally foreseeing - Removing all the tags with less than 5 images knocked off a bunch, and I decided to excise entirely the 'Person' section (the tags with 5+ photos were mostly full of photos of friends and I decided it wasn't entirely polite to throw a bunch of images online with their names attached without their permission).
I might bring that section back in altered form, and I do picture the number of tags increasing as time goes on, but in the short term I think we're close to what we're going to have and it'd probably be time to think about how to display it better in its abbreviated form. For one, I think the margins between the sections of tags can increase. And I think going back to 3 columns might be a good idea, as well as increasing the spacing between columns. What say you all?
Though I should say, I'm thrilled with how this is functioning right now!
Ok. If there are going to be fewer tags than we expected, let's make a few adjustments:
• increase the type size to 20px (to match the font size everywhere else) • change this to three columns • all dark gray and light gray boxes should hover to black • adjust the boxes so they are more centered (ie they seem a tad top heavy at the moment) • also the idea was for this listing to work as a megadropdown; is that still your plan?
Otherwise, this looks great, Marty. Great that you got it to work with CSS!
Oh, and I think we should have a bit more space between the categories. Let's do one whole line break so that all the type stays on the same baseline grid.
@gehalber Type size increase, done. Three columns, done. Hover to black, done. Spacing within boxes, done.
I've done what I can (with the CSS technique we're using) to get the columns to line up. The CSS determines where the column breaks should be, and it's putting some of the padding into the top of the third column, rather than the bottom of the second (where a human would). Without major changes, we don't have too much control over that choice. As the number of tags changes, that choice will change.
Megadrop-down: It's much easier to have this be its own page. If we do this as a shade, we'll encounter many of the same concerns we have with the info box (since we'll be doing it the same way). In the meantime, I've added the link to the header.
Personally, I'm fine with it being its own page, though I'll default to Geoff and Kyle on this one...
I’m fine with that too. Looks nice. Can we keep news in the top nav on that page?
On Jun 1, 2014, at 9:31 PM, ncalcott notifications@github.com wrote:
Personally, I'm fine with it being its own page, though I'll default to Geoff and Kyle on this one...
— Reply to this email directly or view it on GitHub.
@gehalber News issue aside (opening its own issue for that), is there anything else on the Index page? Or can we close this one?
Looks great. One thing about the secondary nav on the right. Can you have these links hover to blue. Thanks.
On Jun 1, 2014, at 10:35 PM, Marty Spellerberg notifications@github.com wrote:
@gehalber News issue aside (opening its own issue for that), is there anything else on the Index page? Or can we close this one?
— Reply to this email directly or view it on GitHub.
Done
@gehalber @ncalcott The columns not lining up on this screen was bugging me, so I did some quick tweaking and was able to improve it.
Great!
On Jun 12, 2014, at 12:46 AM, Marty Spellerberg notifications@github.com wrote:
@gehalber @ncalcott The columns not lining up on this screen was bugging me, so I did some quick tweaking and was able to improve it.
— Reply to this email directly or view it on GitHub.
Like so: