search

eveseat / eseye

👾 A Standalone, Dynamic ESI (EVE Swagger Interface) Client Library written in PHP
GNU General Public License v2.0
50 stars 30 forks source link

Implement If-None-Match #33

Closed leonjza closed 5 years ago

leonjza commented 6 years ago

https://developers.eveonline.com/blog/article/esi-etag-best-practices

warlof commented 6 years ago

addressed in eveseat/eseye#34

Eingang commented 6 years ago

Do we need to do something to make it honour it, like track/store the eTags and include the last known one in our requests with a "If-None-Match" match header?

I'm wondering because, unlike my previous XML-based library, Notification ESI calls are returning every single Notification I have every single time, even if nothing has changed. It's a bit odd!

warlof commented 6 years ago

Check pr upper

leonjza commented 6 years ago

I still need to work through this PR still, but the end result in Eseye will be an extra property on the EsiResponse object with the Etag value, and if it matches based on a cached value.