eveseat / seat

🌀✳️ SeAT: A Simple, EVE Online API Tool and Corporation Manager
https://eveseat.github.io/docs/
GNU General Public License v2.0
434 stars 142 forks source link

Auto Squads Not Gaining Correct Users #702

Closed tohuw closed 3 years ago

tohuw commented 4 years ago
tohuw commented 4 years ago

Ok, I've detected a critical pattern. If a given user links any new character, they are added to the correct squads.

Signing out and in, changing main character, and similar actions don't cause them to be added to the squad. ONLY linking works.

What does that mean?

warlof commented 4 years ago

can you provide a squad configuration including filter rules ?

tohuw commented 4 years ago

image image

warlof commented 3 years ago

Ok, regarding the main character update, it's normal that it don't apply change to a squad. Squads only track for certain changes, more precisely, changes related to available filters.

An user which is changing his main do not result in a character change. The originate and target character are still in the same alliance and corporation. They also still have the same assets and skills. Last but not least, they're still the same.

Squads filters are not apply to a main thing, they're applied to users and data they're owning.

lk77 commented 3 years ago

Hello,

i've created a squad in auto mode, and it's empty, what is the solution ?

there is no artisan command to trigger an update of the squads members.

thanks.

warlof commented 3 years ago

Hi,

To provide assistance, we need information. What your squad setup looks like?

lk77 commented 3 years ago

It's just a corporation filter :

Corporation | Is | {name of the corp}

in the filters

and in the type select, auto is selected.

Capture d’écran (1) Capture d’écran (2)

roles does not have permissions yet, perhaps it's the issue

warlof commented 3 years ago

No, squad do not relay on permissions. They only maintain roles attached to an user account

Nfinished commented 3 years ago

Anecdotally I've found that users who log in with only the publicData scope don't seem to get added to auto squads. After requiring them to log in with an additional killmails scope the problem seems to have gone away.

lk77 commented 3 years ago

We had a job issue it seems, we had scheduled commands that were removed from seat v4, and scheduler failed to execute some commands, i think jobs were not created in the first place to update the squads. I've removed everything from the scheduler and added back the commands that still exists and it works.

warlof commented 3 years ago

@lk77 do you have the list of said commands? Normally all v3 command should be drop by the seeder. But I may forgot one or the other.

lk77 commented 3 years ago

some commands were from packages like seat-groups that were removed, i don't think that it was seat own commands