Tracking Upstream PR - Allow ts3server URLs as custom links.

eveseat / seat

🌀✳️ SeAT: A Simple, EVE Online API Tool and Corporation Manager

https://eveseat.github.io/docs/

GNU General Public License v2.0

434 stars 142 forks source link

Tracking Upstream PR - Allow ts3server URLs as custom links. #750

Closed maxtsero closed 3 years ago

maxtsero commented 3 years ago

Problem: It's currently not possible to add a link directly to a TeamSpeak3 server as the Laravel Validator doesn't support the ts3server URI scheme.
Expected: The URI scheme is valid and should, therefore work!
Version Info: PHP 7.3, SeAT Current Stable, Ubuntu 20.04.
Other Info: An Upstream PR has been opened already. Once this is merged we just need to bump the laravel/framework version appropriately.

warlof commented 3 years ago

Wrong repository. Please open it on third party seat-connector.

Also, SeAT is using Laravel LTS, which is currently 6.x.

xcrf commented 3 years ago

@warlof I think this is tracking the customlink feature in the web package for the sidebar menu.

warlof commented 3 years ago

Oh, sorry - I miss understand the case. However, SeAT is still targeting LTS version

maxtsero commented 3 years ago

Probably right to close this @warlof - it's logged now and will show up if someone has the issue. If Laravel accept the PR it will eventually trickle down and work in SeAT :-)

warlof commented 3 years ago

All right, closing it then.

homotechsual commented 3 years ago

Thanks :-) Laravel merged the fix, so eventually it'll make it's way through to SeAT, until then you can either edit the Laravel Framework package (or patch it) or use https redirection to link to your TS server by linking as https://invite.teamspeak.com/ts.yourserver.uk/?password=yourserverpassword