search

eveseat / seat

🌀✳️ SeAT: A Simple, EVE Online API Tool and Corporation Manager
https://eveseat.github.io/docs/
GNU General Public License v2.0
430 stars 143 forks source link

[Bug] Auto squad doesn't auto-add public scope users #770

Closed Nfinished closed 3 years ago

Nfinished commented 3 years ago

I've got an auto squad that I use to assign basic roles such as connector access. The only filter is that a user is not a certain character, so I'd expect everyone should be added to the squad on signing in.

Users can sign in with one of two scopes. One scope is everything, and the other is public data and killmails. All users who log in with the everything scope are correctly added to the auto squad. Users who log in with the public scope are never added to the squad. This happens 100% of the time.

All packages latest.

muzixa commented 3 years ago

EDIT: Now no errors on squad edit, but characters adding only after squad filter editing

warlof commented 3 years ago

Squads rules are processed only on rules update, if squads is altered. Otherwise, it's done dynamically based on applied filter and the data source to which it's attached.

muzixa commented 3 years ago

Sorry, my english not so good. Maybe i do not understand it but i have auto squad +corporation based filter. When i change some filters it's works and immediately adding all characters who is in corporation. Then i register new character (in same corp) but he is not adding to this squad automatically, if im editing squad filters again he is adding fine after submit changes.

EDIT: checked again, it's works fine with full scopes, but with only public scope & killmails still not working. Updated yesterday.

+--------------------+---------------+----------------+ | Package Name | Local Version | Latest Version | +--------------------+---------------+----------------+ | SeAT API | 4.5.0 | 4.5.0 | | SeAT Console | 4.8.0 | 4.8.0 | | SeAT Eve API | 4.10.1 | 4.10.1 | | SeAT Notifications | 4.3.1 | 4.3.1 | | SeAT Services | 4.2.0 | 4.2.0 | | SeAT Web | 4.10.0 | 4.10.0 | +--------------------+---------------+----------------+

warlof commented 3 years ago

the thing you're talking about is covered by https://github.com/eveseat/web/pull/559 which has not been released yet.

muzixa commented 3 years ago

the thing you're talking about is covered by eveseat/web#559 which has not been released yet.

Ok, thank you very much

muzixa commented 3 years ago

Checked one more time. And im think this is not only public scope issue. What i done:

1.Authed 1st character with public scope+killmails -> character not added to squad, Authed same character with full scope (without deletinon user) -> character added to squad.

  1. Authed 2nd character with full-scope -> character not added to squad, Authed 2nd character with public+killmails (without deletinon user) -> character added to squad.

It seems auto-squads works for me after some change done with squad filter or character.

muzixa commented 3 years ago

Seems there are just some delay for auto-squads, all characters was added automatically in 1 hour. So, all works

But if auth from one char twice (even with the same scopes), squad filter works immediately