search

eveseat / seat

🌀✳️ SeAT: A Simple, EVE Online API Tool and Corporation Manager
https://eveseat.github.io/docs/
GNU General Public License v2.0
434 stars 142 forks source link

[Feature Request] Make SSO login URL and Image Server URL really configurable #815

Open copyliu opened 3 years ago

copyliu commented 3 years ago

as https://github.com/eveseat/seat/issues/800#issuecomment-819816460

Everything else should be configurable in the .env file

hard-coded URL was find in https://github.com/eveseat/services/blob/master/src/Socialite/EveOnline/Provider.php#L60 https://github.com/eveseat/eveapi/blob/master/src/Commands/Seat/Tokens/Upgrade.php#L73 https://github.com/eveseat/eseye/blob/master/tests/Fetchers/GuzzleFetcherTest.php#L221

For a Serenity instance, it's good to make them configurable via .env file EVE_SSO_HOST

also hard-coded URL https://github.com/eveseat/services/blob/master/src/Image/Eve.php#L72 it's good to make them configurable too

tehraven commented 2 years ago

@copyliu this is actually fairly easy to accomplish! You should make the pull requests for this and make the mod team's life easy here.

You can see default / existing env configs defined here: https://github.com/eveseat/eveapi/blob/79698f36714d8ac4d4587b1cee2ed84a90c4701a/src/Config/esi.php#L42

And you can pull that into your code with:

config('esi.eseye_sso_port')

:)