eveseat / seat

🌀✳️ SeAT: A Simple, EVE Online API Tool and Corporation Manager
https://eveseat.github.io/docs/
GNU General Public License v2.0
425 stars 143 forks source link

Duplicate New Application Notifications #884

Closed eeverett91 closed 1 year ago

eeverett91 commented 1 year ago
eeverett91 commented 1 year ago

Perhaps its noteworthy that I have tokens for 5 characters with the personnel manager role in SeAT. Maybe it's sending one per toon/token that receives the notification?

Crypta-Eve commented 1 year ago

Perhaps its noteworthy that I have tokens for 5 characters with the personnel manager role in SeAT. Maybe it's sending one per toon/token that receives the notification?

Yes that is correct. For each affiliated token we will directly forward the notification. I suggest reducing down to only one token.

eeverett91 commented 1 year ago

I think I'll disable the notification. The tokens belong to toons from multiple players; recruiters + CEO + Directors. I would prefer not to remove their tokens.

Perhaps a feature request for the future could be to look for duplicate notifications and only send one?

Crypta-Eve commented 1 year ago

I think I'll disable the notification. The tokens belong to toons from multiple players; recruiters + CEO + Directors. I would prefer not to remove their tokens.

You don't need to remove their tokens, just not include them in the notification groups affiliation list. Likewise if you have in the affiliation the corp, that matches all toons of the corp. So just place day the CEO in the affiliation.

Perhaps a feature request for the future could be to look for duplicate notifications and only send one?

It's something we should look into yes, but deduplicating is not always trivial.

eeverett91 commented 1 year ago

I think I'll disable the notification. The tokens belong to toons from multiple players; recruiters + CEO + Directors. I would prefer not to remove their tokens.

You don't need to remove their tokens, just not include them in the notification groups affiliation list. Likewise if you have in the affiliation the corp, that matches all toons of the corp. So just place day the CEO in the affiliation.

Ah I'm following now, I'll do that thanks.

Perhaps a separate topic but any idea why the character name is coming up as unknown in the notification? The link to zKill works fine.

warlof commented 1 year ago

Close as duplicate of #680