search

evgenekov / protobuf-csharp-port

Automatically exported from code.google.com/p/protobuf-csharp-port
Other
0 stars 0 forks source link

IBuilder misses ClearField method. #83

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
IBuilder has SetField but ClearField. ClearField is useful when working with 
reflection, just like SetField.

Original issue reported on code.google.com by igorga...@gmail.com on 2 Apr 2014 at 2:50

GoogleCodeExporter commented 9 years ago 
Yup, that makes sense. Taking a look now.

Original comment by jonathan.skeet on 2 Apr 2014 at 6:01

GoogleCodeExporter commented 9 years ago 
Actually, it looks like this already exists - there's IBuilder<,>.ClearField, 
and IBuilder.WeakClearField.

I can't see any *tests* for it at the moment, so I'll add those... but I think 
it's otherwise okay. What might I have missed?

Original comment by jonathan.skeet on 2 Apr 2014 at 6:18

GoogleCodeExporter commented 9 years ago 
Added a test now - it looks like we already had a test for clearing extensions 
with reflection. Anything else required, or can I close this?

Original comment by jonathan.skeet on 2 Apr 2014 at 3:52

GoogleCodeExporter commented 9 years ago 
Oh, I did not spot WeakClearField. Yea, you can close this. Thanks!

Original comment by igorga...@gmail.com on 4 Apr 2014 at 11:48

GoogleCodeExporter commented 9 years ago

Original comment by jonathan.skeet on 4 Apr 2014 at 12:20