evgenyneu / Auk

An image slideshow for iOS written in Swift.
MIT License
277 stars 44 forks source link

UIScrollViewDelegate is called too many times #29

Closed danielpassos closed 8 years ago

danielpassos commented 8 years ago

Any reason for scrollViewDidScroll be called too many times? just curious!

override func viewDidLoad() {
    scrollView.auk.settings.preloadRemoteImagesAround = 2
    scrollView.auk.settings.showsHorizontalScrollIndicator = true
    scrollView.auk.settings.pageControl.visible = true
    scrollView.auk.settings.contentMode = UIViewContentMode.ScaleAspectFill

    let image1 = UIImage(named: "banner_top.jpg")
    self.scrollView.auk.show(image: image1!, accessibilityLabel: "Top")

    let image2 = UIImage(named: "banner_conteudo.jpg")
    self.scrollView.auk.show(image: image2!, accessibilityLabel: "Conteúdo")

    let image3 = UIImage(named: "banner_eventos.jpg")
    self.scrollView.auk.show(image: image3!, accessibilityLabel: "Eventos")

    scrollView.auk.startAutoScroll(delaySeconds: 3)
}
func scrollViewDidScroll(scrollView: UIScrollView) {
    print(scrollView.auk.currentPageIndex)
}
Optional(0)
Optional(0)
Optional(0)
Optional(0)
Optional(0)
Optional(0)
Optional(0)
Optional(0)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(1)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
Optional(2)
evgenyneu commented 8 years ago

I noticed it as well. The scrollViewDidScroll method is called very frequently as the user changes the scrolling position of the scroll view. From Apple documentation of scrollViewDidScroll method

Tells the delegate when the user scrolls the content view within the receiver.

I guess this is how this delegate method is supposed to work so we can run some code as the user changes the scroll position of the scroll view.

danielpassos commented 8 years ago

Make sense