evgenyneu / Auk

An image slideshow for iOS written in Swift.
MIT License
278 stars 44 forks source link

ScrollView Infinite Looping #38

Open lichenglu opened 8 years ago

lichenglu commented 8 years ago

First of all, thank you so much for the project, love it a lot! I wonder is it possible to add infinite looping for scrollView without much work? Now the looping is a bit weird, because if I hit the right-most view, and want it to go back to the first view, I will need to left-swift several times, rather than just right swipe one time. If so, could you give me some suggestions so that I could add this feature and open a pull request maybe?

evgenyneu commented 8 years ago

Hi @lichenglu, this will be a nice feature to have, thanks for bringing it up. I am not sure how to do it. Maybe it is easy, please feel free to investigate.

evgenyneu commented 8 years ago

I found an existing library that offers the infinite scrolling: https://github.com/zvonicek/ImageSlideshow

lichenglu commented 8 years ago

I am actually using this library now because of its infinite loop feature. I will see if I can add this feature based on yours

evgenyneu commented 8 years ago

@lichenglu great, if ImageSlideshow works for you well no need to add infinite scroll to Auk. Unless you really want to :). I would rather keep Auk simple and focused so it can do few things really well rather than trying to do everything for everyone, if you know what I mean.

lichenglu commented 8 years ago

Make sense to me! I will not try to add this feature then :)

kashlo commented 7 years ago

I was unable to use https://github.com/zvonicek/ImageSlideshow in my project But Auk worked liked a charm :) so implementing infinite scrolling would be great

evgenyneu commented 7 years ago

Thanks for your suggestion, @zakusha. I will think if this can be done without sacrificing the simplicity and reliability of the library. Suggestions are welcome as well.

cardyng commented 7 years ago

I like Auk very much! Thanks for developing it. And It would be great if it can have infinite scroll function :)

Muvidevelopers commented 7 years ago

@evgenyneu Did infinite scroll get implemented?

evgenyneu commented 7 years ago

@Muvidevelopers, no, it has not been implemented yet, unfortunately. Sorry :)