Cosmos RTL not working properly inside UITableView

evgenyneu / Cosmos

A star rating control for iOS/tvOS written in Swift

MIT License

2.18k stars 367 forks source link

Cosmos RTL not working properly inside UITableView #151

Open mubashirhussain opened 4 years ago

mubashirhussain commented 4 years ago

Please consider submitting the following information (if relevant):

Library setup method: file, Carthage, CocoaPods or Swift Package Manager.
Version of the library. Example: 20.0.1
Xcode version. Example: 11.1
OS version. Example: iOS 13.1

Half of the rows displayed are correct but the other half created from the reused cell is not correct.

abdallahnh commented 4 years ago

Having the same issue, was this solved?

freemansion commented 1 week ago

Had the same issue with CosmosView instance embedded into UICollectionViewCell and RTL content semantics. My workaround to bypass this issue is to wrap view configuration code into async update with GCD.

if RTL {
  DispatchQueue.main.async {
      self.ratingView.rating = stars
  }
} else {
    ratingView.rating = stars
}

Aforementioned hack, schedules ratingView aka CosmosView is being updated after collection view methods did their job. Looks like race condition issue.