Fix rating update responsiveness in Demo (main controller)

evgenyneu / Cosmos

A star rating control for iOS/tvOS written in Swift

MIT License

2.18k stars 366 forks source link

Fix rating update responsiveness in Demo (main controller) #160

Closed MaxZheleznyy closed 4 years ago

MaxZheleznyy commented 4 years ago

Old behavior - https://d.pr/v/tItCsG

Suggested behavior - update all ratings at the same time

Reasons:

Current version requires a user to remember which rating is currently working with the score scale
I (as a user) may want to see how other ratings will change based on a change with a specific rating

(possible) Interesting information:

Version of the library - 21.0.0
Xcode version - 11.3.1 (11C504)
OS version - Any

evgenyneu commented 4 years ago

@MaxZheleznyy, thanks, sorry I don't understand what you want to accomplish in the demo app. Can you explain a bit more please?

MaxZheleznyy commented 4 years ago

@evgenyneu absolutely

From my point of view, the current system is a little bit misleading. I (as a user) expect that every rating (Full, Half and Precise) will be updated no matter which one has changed. Without such functionality, a user ended up wondering (especially if he/she got distracted for a moment) - why is the rating slider showing me 4 (for example), but "Full" rating is only 2 (again as an example). The first thought, for such behavior, is "have I broken something?".

Hope that will give you an idea ;)

MaxZheleznyy commented 4 years ago

@evgenyneu hi 👋 Will be pleased to hear your thoughts/suggestions/questions about my previous comment

evgenyneu commented 4 years ago

@MaxZheleznyy thanks for the reminder. That's awesome, thanks for improving the demo app.

MaxZheleznyy commented 4 years ago

awesome 👏 Thank you for such a great app 👍