search

evgenyneu / Cosmos

A star rating control for iOS/tvOS written in Swift
MIT License
2.18k stars 366 forks source link

Bugfix/162 wrong color on light mode switch #163

Closed dkk closed 4 years ago

dkk commented 4 years ago

Fixes bug #162

Additionally:

evgenyneu commented 4 years ago

Thanks for the update.

I have missing constraints errors in your branch. I think it happened because you have added height constraints. Cosmos view does not need height or width constraints because the size of the view is determined by the sizes of the stars inside it. Sometimes storyboard shows warnings, it's just enough to select the affected view and choose "Editor > Size to fit content".

dkk commented 4 years ago

Strange, I actually only added the height constraints to solve the missing constraints errors. I reverted my changes on the storyboard.

evgenyneu commented 4 years ago

Thanks for the update!

I actually only added the height constraints to solve the missing constraints errors.

I see, the storyboard editor is a bit buggy and often shows error/warnings after Xcode update.