Closed kloczek closed 1 year ago
evhub
commented
1 year ago Please stop posting this here. I am never going to fix this. I have told you this repeatedly (#630, #716, #741) in the past.
This is your last warning. If you post this same issue here again, I will ban you from interacting with this repository and any other repositories that I own.
kloczek
commented
1 year ago OK I'll add note to my spec files to not bother you again however why test suite which is using pytest module needs to executed by not using pytest command? 🤔
Is it any particular reason to confuse someone like me using that that way? 🤔
As errors and fails are changing I've assumed that you actually fixed reported issues ..
evhub
commented
1 year ago As I've explained previously, Coconut's testing suite is only ever intended to be run in the exact development environment of Coconut's testing suite. In that environment, there are no errors and fails (at least in any released version), everything works just fine (https://github.com/evhub/coconut/actions/runs/5699294862), but Coconut's testing suite is not intended to be used by the end user in any situation.
kloczek
commented
5 months ago Please forgive me .. I have just last question about testing topic.
If some units are working only in some very specific env maybe it would be good to add some pytest mark like ci or so to be able nasypy enable those units? 🤔 (default IMO shuld be skip those units)
I'm sure that other people may be asking similar questions causing only your frustration ..
If you will give me list od those units which should be skipped outside of CI I can try to prepare PR for that. Would you accept such PR? 🤔 if yes please just choose name of such pytest mark. 'ci' would be OK? 🤔
For now in my rpm spec file I have below list of units which are failing.
%check
%pytest coconut/tests %{!?with_failing_tests: \
--deselect coconut/tests/constants_test.py::TestConstants::test_imports \
--deselect coconut/tests/main_test.py::TestCompilation::test_and \
--deselect coconut/tests/main_test.py::TestCompilation::test_incremental \
--deselect coconut/tests/main_test.py::TestCompilation::test_keep_lines \
--deselect coconut/tests/main_test.py::TestCompilation::test_mypy_sys \
--deselect coconut/tests/main_test.py::TestCompilation::test_no_tco \
--deselect coconut/tests/main_test.py::TestCompilation::test_no_wrap \
--deselect coconut/tests/main_test.py::TestCompilation::test_normal \
--deselect coconut/tests/main_test.py::TestCompilation::test_package \
--deselect coconut/tests/main_test.py::TestCompilation::test_run_arg \
--deselect coconut/tests/main_test.py::TestCompilation::test_run_dir \
--deselect coconut/tests/main_test.py::TestCompilation::test_standalone \
--deselect coconut/tests/main_test.py::TestCompilation::test_strict \
--deselect coconut/tests/main_test.py::TestCompilation::test_target \
--deselect coconut/tests/main_test.py::TestExternal::test_prelude \
--deselect coconut/tests/main_test.py::TestExternal::test_pyprover \
--deselect coconut/tests/main_test.py::TestShell::test_import_hook \
--deselect coconut/tests/main_test.py::TestShell::test_jupyter_console \
--deselect coconut/tests/main_test.py::TestShell::test_kernel_installation \
--deselect coconut/tests/main_test.py::TestShell::test_xontrib \
}Is that all? 🤔 I'm asking because have some ebven very limited possibility to test your module in some other envs is quite important. Simple "something is always better than nothing".
I'm packaging your module as an rpm package so I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.
python3 -sBm build -w --no-isolationbuildwith--no-isolationI'm using during all processes only locally installed modulescut off from access to the public network(pytest is executed with-m "not network")Here is pytest output:
Here is list of installed modules in build env