fix: support 0 as a `sidebar_position`

evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown

https://evidence.dev

MIT License

3.44k stars 167 forks source link

fix: support 0 as a `sidebar_position` #1884

Closed AyushAgrawal-A2 closed 1 month ago

AyushAgrawal-A2 commented 1 month ago

Description

closes #1797

Changes:

In the if check - if (a.frontMatter?.sidebar_position && b.frontMatter?.sidebar_position), we need to check whether the sidebar_position value exists. However 0 being a falsy value, if sidebar_position is 0 then also the check evaluates to false. This is fixed by using isNaN function.
Updated sidebar_position for All Components in docs from -1 to 0, where -1 was used as a workaround.

Checklist

[ ] For UI or styling changes, I have added a screenshot or gif showing before & after
[x] I have added a changeset
[ ] I have added to the docs where applicable
[ ] I have added to the VS Code extension where applicable

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 353af4c171747b778ae6012d65a8b9762f8f095c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

| Name | Type | | ----------------------------- | ----- | | @evidence-dev/core-components | Patch | | @evidence-dev/evidence | Patch | | my-evidence-project | Patch | | @evidence-dev/components | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 month ago

Deploy Preview for evidence-development-workspace ready!

Name	Link
Latest commit	353af4c171747b778ae6012d65a8b9762f8f095c
Latest deploy log	https://app.netlify.com/sites/evidence-development-workspace/deploys/661a65e28be9640008d53431
Deploy Preview	https://deploy-preview-1884--evidence-development-workspace.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.