Open AyushAgrawal-A2 opened 1 month ago
Latest commit: 8300b3b5752f20d911609d0be2eb60763cf548df
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 8300b3b5752f20d911609d0be2eb60763cf548df |
Latest deploy log | https://app.netlify.com/sites/evidence-development-workspace/deploys/66468d37918b200008c4771c |
Deploy Preview | https://deploy-preview-1887--evidence-development-workspace.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 8300b3b5752f20d911609d0be2eb60763cf548df |
Latest deploy log | https://app.netlify.com/sites/next-docs-evidence/deploys/66468d37d8a5b8000874edd8 |
Deploy Preview | https://deploy-preview-1887--next-docs-evidence.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks for the PR!
One concern: seems like queries with string-enclosed "comments" are also caught here, which could be an issue if it's used as a delimiter or such in a string input (i.e. New York -- NY
)
@csjh Sorry, I missed that edge case. Tackling this requires parsing the query, I don't think it can be done via simple regex replace. I have added a helper function to do so.
This is required in 3 packages. In order to avoid cross package dependencies I have added this in all three packages. But I don't believe duplicate code is good. Please suggest if there is a common place to place this function. I tried placing it in db-commons but it create a cyclic dependency betweet QueryStore and db-commons.
Before:
After:
This is required in 3 packages. In order to avoid cross package dependencies I have added this in all three packages. But I don't believe duplicate code is good. Please suggest if there is a common place to place this function. I tried placing it in db-commons but it create a cyclic dependency betweet QueryStore and db-commons.
This should only be used in the query-store
(which is now sdk/usql/query.js
), and that should cover the impacted area
Name | Link |
---|---|
Latest commit | 8300b3b5752f20d911609d0be2eb60763cf548df |
Latest deploy log | https://app.netlify.com/sites/evidence-test-env/deploys/66468d371e8325000885772f |
Deploy Preview | https://deploy-preview-1887--evidence-test-env.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
This is required in 3 packages. In order to avoid cross package dependencies I have added this in all three packages. But I don't believe duplicate code is good. Please suggest if there is a common place to place this function. I tried placing it in db-commons but it create a cyclic dependency betweet QueryStore and db-commons.
This should only be used in the
query-store
(which is nowsdk/usql/query.js
), and that should cover the impacted area
@ItsMeBrianD Done
This is ready to be merged, but going to hold off until after the release so there is a testing window on next
, thanks for the contribution!
Description
closes #733 closes #1735 closes #1450
Changes:
;
in query.QueryStore
and fixes bug in chained query due to trailing;
.Before:
After:
Checklist