Open AyushAgrawal-A2 opened 1 month ago
Latest commit: 9ba8e2b519d5bc258fe93b34f27fc3355302802c
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 9ba8e2b519d5bc258fe93b34f27fc3355302802c |
Latest deploy log | https://app.netlify.com/sites/evidence-development-workspace/deploys/662173599d78fb00096cbf8c |
Deploy Preview | https://deploy-preview-1893--evidence-development-workspace.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 9ba8e2b519d5bc258fe93b34f27fc3355302802c |
Latest deploy log | https://app.netlify.com/sites/next-docs-evidence/deploys/6621735954bf3f00073b8b57 |
Deploy Preview | https://deploy-preview-1893--next-docs-evidence.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Can you add a test case to the example-project
to show this working?
@archiewood I have added test case to example-project at /input-components/date-range/
Date Error (solved by modifying dateToYYYYMMDD
fn)
Infinite reactive call & limited date range error - (Screencast after solving date error) before.webm
After: after.webm
Description
closes #1875 closes #1892
Problems Identified:
query
depends ondata
which depends on$input[name].(start & end)
which depends onstartString
&endString
which depends back onquery
.$query
is required to be run once to get date range for available data, but here it is getting triggered repeatedly due to reactive dependencies. When$query
was being refetched startString null coalesce to epoch0 and endString null coalesce to todays date.selectedDateRange
changes$input[name].(start & end)
which changesstartString
&endString
due to above mentioned infinite call. This disables dates outside current selection.dateToYYYYMMDD
function usedDate.toISOString()
method, which has date in UTC format. This results in previous date for some locale. This combined with infinite call bug, was repeatedly decrementing end date.Checklist