evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
3.38k stars 163 forks source link

Fix header link sizes #1899

Closed archiewood closed 3 weeks ago

archiewood commented 3 weeks ago

Checklist

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 779ba49dabe6dd10914cf470c506a14c136ed6fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | ----------------------------- | ----- | | @evidence-dev/core-components | Patch | | @evidence-dev/evidence | Patch | | my-evidence-project | Patch | | @evidence-dev/components | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 weeks ago

Deploy Preview for next-docs-evidence ready!

Name Link
Latest commit 779ba49dabe6dd10914cf470c506a14c136ed6fa
Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/661ee438193ef30008bc0a10
Deploy Preview https://deploy-preview-1899--next-docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit 779ba49dabe6dd10914cf470c506a14c136ed6fa
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/661ee438de91c100080cbdb6
Deploy Preview https://deploy-preview-1899--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

archiewood commented 3 weeks ago

Fixes #1896

A better solution might be to always inherit sizing for links

mcrascal commented 3 weeks ago

LGTM -- only thing is this edge cases table looks broken enough right now that it'll be hard to know if there's a regression.