Reintroduce error handling to DataTable

evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown

https://evidence.dev

MIT License

3.38k stars 164 forks source link

Reintroduce error handling to DataTable #1926

Closed hughess closed 2 weeks ago

hughess commented 2 weeks ago

Description

Errors in DataTable were breaking the page. This patches over a couple of common errors:

data prop passed as a string instead of using { }
Incorrect column name passed to Column

Incorrect column name error is not handling well here, but better than breaking the page - it currently inserts an empty column with title "undefined"

Examples

CleanShot 2024-04-21 at 15 47 56@2x

CleanShot 2024-04-21 at 15 48 10@2x

Checklist

[x] For UI or styling changes, I have added a screenshot or gif showing before & after
[x] I have added a changeset

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 41a9f1b56bed6230d6a4114ee13b63cc6bf877ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

| Name | Type | | ----------------------------- | ----- | | @evidence-dev/core-components | Patch | | @evidence-dev/evidence | Patch | | my-evidence-project | Patch | | @evidence-dev/components | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 weeks ago

Deploy Preview for next-docs-evidence ready!

Name	Link
Latest commit	41a9f1b56bed6230d6a4114ee13b63cc6bf877ee
Latest deploy log	https://app.netlify.com/sites/next-docs-evidence/deploys/66256e66607b9400087137dc
Deploy Preview	https://deploy-preview-1926--next-docs-evidence.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.