evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
3.38k stars 164 forks source link

feat: add show/hide/never sidebar toggle in frontmatter #1927

Closed AyushAgrawal-A2 closed 5 days ago

AyushAgrawal-A2 commented 2 weeks ago

Description

closes #1468

Changes:

Checklist

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 261d94952d792b55ef4401dd1404142db72ee765

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | ----------------------------- | ----- | | @evidence-dev/core-components | Minor | | my-evidence-project | Minor | | @evidence-dev/components | Minor | | @evidence-dev/evidence | Major | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 weeks ago

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit 261d94952d792b55ef4401dd1404142db72ee765
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/662663f5b9552f00084a9cf7
Deploy Preview https://deploy-preview-1927--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for next-docs-evidence ready!

Name Link
Latest commit 261d94952d792b55ef4401dd1404142db72ee765
Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/662663f5715c7b00080d6f0b
Deploy Preview https://deploy-preview-1927--next-docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mcrascal commented 2 weeks ago

Looks great -- in the hide configuration, I think we'd want to bring the left edge of the header in such that the sidebar button is aligned with the left edge of the content.

AyushAgrawal-A2 commented 2 weeks ago

Looks great -- in the hide configuration, I think we'd want to bring the left edge of the header in such that the sidebar button is aligned with the left edge of the content.

@mcrascal Done

image