Closed hughess closed 1 week ago
Latest commit: 63908810d17dfc77b4ab8546d0f2721434dba995
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 63908810d17dfc77b4ab8546d0f2721434dba995 |
Latest deploy log | https://app.netlify.com/sites/evidence-development-workspace/deploys/662966f1ef04d9000737b8bc |
Deploy Preview | https://deploy-preview-1939--evidence-development-workspace.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 63908810d17dfc77b4ab8546d0f2721434dba995 |
Latest deploy log | https://app.netlify.com/sites/next-docs-evidence/deploys/662966f13818d800098f68b1 |
Deploy Preview | https://deploy-preview-1939--next-docs-evidence.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@mcrascal this seems to work well, but a couple things I wasn't sure about on this one:
article
or main
the right place for the extra padding/margin?@hughess this seems totally fine, but I think the extra space should be added to the charts themselves. As an example, datatable
doesn't cause this bug because it includes sufficient space to accommodate the download buttons.
With this fix, I think this will crop up again when composing charts into wrapper components (like a modal), or when people are building custom components.
Description
When hovering the last chart on a page, occasionally a scroll would appear on the page.
This adds padding to the article to eliminate the scrollbar.
Before
After
Checklist