evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
3.44k stars 167 forks source link

fix: adds bottom margin on LinkButton #1947

Closed yashhhguptaaa closed 2 weeks ago

yashhhguptaaa commented 3 weeks ago

Description

Resolves #1125

Screenshot 2024-04-27 at 11 16 43 AM

Checklist

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 3e207426c9656e030e400a93e1ebcbd745f3c913

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | ----------------------------- | ----- | | @evidence-dev/core-components | Patch | | @evidence-dev/evidence | Patch | | my-evidence-project | Patch | | @evidence-dev/components | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 weeks ago

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit 3e207426c9656e030e400a93e1ebcbd745f3c913
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/662e4e85119bef0008083240
Deploy Preview https://deploy-preview-1947--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for next-docs-evidence ready!

Name Link
Latest commit 3e207426c9656e030e400a93e1ebcbd745f3c913
Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/662e4e855f9fab0008cb5014
Deploy Preview https://deploy-preview-1947--next-docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

archiewood commented 3 weeks ago

Looks good. Can you add a changeset?

yashhhguptaaa commented 3 weeks ago

Looks good. Can you add a changeset?

Done 9e8f8b1

archiewood commented 3 weeks ago

This should be a patch bump - you can change the file to just say "patch" rather than "major"

(Changesets are how we manage semantic versions)

yashhhguptaaa commented 3 weeks ago

This should be a patch bump - you can change the file to just say "patch" rather than "major"

(Changesets are how we manage semantic versions)

Ohh, my bad, missed that. Done

yashhhguptaaa commented 2 weeks ago

This should be a patch bump - you can change the file to just say "patch" rather than "major" (Changesets are how we manage semantic versions)

Ohh, my bad, missed that. Done

@archiewood Can we merge this? I've added the changesets as well.