evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
3.44k stars 167 forks source link

Support for AAD authentication in MSSQL connector #1953

Open mycaule opened 2 weeks ago

mycaule commented 2 weeks ago

Description

I needed to use this block to be able to login with Active Directory. This is useful if the database uses a passwordless strategy.

authentication: {
    type: "azure-active-directory-default"
  }

Check also https://github.com/timothyhoward/evidence-connector-mssql/pull/1

Screenshots

Screenshot 2024-05-01 at 14 08 17 Screenshot 2024-05-01 at 14 08 30

Checklist

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 636692feb23e26a27e8d73ec5b9f0a8eff699724

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ----------------------------- | ----- | | @evidence-dev/mssql | Minor | | @evidence-dev/db-orchestrator | Patch | | @evidence-dev/components | Patch | | @evidence-dev/evidence | Patch | | my-evidence-project | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 weeks ago

Deploy Preview for docs-evidence ready!

Name Link
Latest commit 3d68c3ac41a85a11b470d627f0c38ca9bbedc6b5
Latest deploy log https://app.netlify.com/sites/docs-evidence/deploys/663240ffd8ef6100084ca54b
Deploy Preview https://deploy-preview-1953--docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit 636692feb23e26a27e8d73ec5b9f0a8eff699724
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/6633d512b105d00009f828d9
Deploy Preview https://deploy-preview-1953--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

archiewood commented 2 weeks ago

@mycaule Thanks for this PR

I feel like SQL login is probably not the right name for the username/pw auth flow?

perhaps Username / Password is more descriptive?

mycaule commented 2 weeks ago

@mycaule Thanks for this PR

I feel like SQL login is probably not the right name for the username/pw auth flow?

perhaps Username / Password is more descriptive?

I used this because it is the vocabulary used by Microsoft, SQL authentication refer to user/pass created in SQL Server As opposed to the username/password in Active Directory of your organization.

You can check this screenshot

https://learn.microsoft.com/en-us/azure-data-studio/connect#new-installation-of-azure-data-studio-140-and-higher

netlify[bot] commented 2 weeks ago

Deploy Preview for next-docs-evidence ready!

Name Link
Latest commit 636692feb23e26a27e8d73ec5b9f0a8eff699724
Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/6633d5120fe5740009757b8e
Deploy Preview https://deploy-preview-1953--next-docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mycaule commented 2 weeks ago

Also added the authentication types @timothyhoward has supported in his plugin.