evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
3.44k stars 167 forks source link

Handle missing values for multiple y columns #1961

Closed hughess closed 2 weeks ago

hughess commented 2 weeks ago

Description

When passing multiple columns to y, using handleMissing did not take effect. This PR iterates through the y columns to set nulls to the appropriate values.

Before

CleanShot 2024-05-02 at 12 45 29@2x

After

CleanShot 2024-05-02 at 12 47 28@2x

Checklist

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 85d017925d40a150d5f5508ec7a02cee251be26e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | --------------------------------- | ----- | | @evidence-dev/component-utilities | Patch | | @evidence-dev/evidence | Patch | | @evidence-dev/core-components | Patch | | my-evidence-project | Patch | | @evidence-dev/components | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 weeks ago

Deploy Preview for next-docs-evidence ready!

Name Link
Latest commit 85d017925d40a150d5f5508ec7a02cee251be26e
Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/6633c31e8f683a0008c638ef
Deploy Preview https://deploy-preview-1961--next-docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit 85d017925d40a150d5f5508ec7a02cee251be26e
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/6633c31e60c65b000777a3ea
Deploy Preview https://deploy-preview-1961--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.