search

evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
4.4k stars 210 forks source link

[Bug]: Dropdown selections are not removed when the query changes to exclude them #2507

Open archiewood opened 2 months ago

archiewood commented 2 months ago

Describe the bug

Reported in Slack

Dependent Dropdown does not deselect the dropdown selections when the query data powering it removes those rows from the selection

https://github.com/user-attachments/assets/70e84260-72a9-49cf-a532-db0c5e235324

Expected behavior

When selecting a store type, the second dropdown should deselect the stores that do not match the selected store type.

Actual behavior

The second dropdown filters the options list correctly, but any previously selected options are not deselected.

Steps to Reproduce

https://github.com/archiewood/tabs-bug

Logs

No response

System Info

No response

Severity

serious, but I can work around it

Additional Information, or Workarounds

No response

zachstence commented 1 month ago

Reopening because I had to revert the PR that closed this issue here: https://github.com/evidence-dev/evidence/pull/2559

kwongz commented 2 weeks ago

@ItsMeBrianD I think we spoke about this being taken care of in your dropdown PR?