evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in SQL and markdown
https://evidence.dev
MIT License
4.5k stars 216 forks source link

Revert "Suppress OCSP warnings in Snowflake Connector" #2639

Closed zachstence closed 1 month ago

zachstence commented 1 month ago

Reverts evidence-dev/evidence#2631

According to the Snowflake team here https://github.com/snowflakedb/snowflake-connector-nodejs/issues/932#issuecomment-2401740255

which we, as Snowflake, generally don't really recommend to do as a permanent 'solution' but here the cert chain cannot fully be validated anyways, so...

Using insecureConnect is not a recommended long-term solution.

I don't want Evidence opening security holes just to quiet a noisy log. The noisy log can stay until we find a way to quiet the log without impacting security, or until the OCSP issue is fixed within Snowflake.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 2e4f1905a08a74ff5c80e4baa1e9e35a710bb40d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 5:09pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 5:09pm
netlify[bot] commented 1 month ago

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit 2e4f1905a08a74ff5c80e4baa1e9e35a710bb40d
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/670807b5ad07520007cb23b2
Deploy Preview https://deploy-preview-2639--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for next-docs-evidence ready!

Name Link
Latest commit 2e4f1905a08a74ff5c80e4baa1e9e35a710bb40d
Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/670807b5d348ff0008a18d49
Deploy Preview https://deploy-preview-2639--next-docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for evidence-test-env ready!

Name Link
Latest commit 2e4f1905a08a74ff5c80e4baa1e9e35a710bb40d
Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/670807b5d548e50008f1a38d
Deploy Preview https://deploy-preview-2639--evidence-test-env.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.