Bump snowflake-sdk to 1.14

GriffGeorge commented 3 weeks ago

Description

Bump the snowflake-sdk version in order to make https://github.com/evidence-dev/evidence/pull/2701 actually work! SSO Caching was introduced in 1.12. This takes us to 1.14 (latest).

Checklist

[x] ~~For UI or styling changes, I have added a screenshot or gif showing before & after~~
[ ] I have added a changeset
[x] ~~I have added to the docs where applicable~~
[x] ~~I have added to the VS Code extension where applicable~~

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: ae0ca46a82407a330c3574863bbf8e8b6c05c95a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

| Name | Type | | ------------------------- | ----- | | @evidence-dev/snowflake | Patch | | e2e-prerender | Patch | | e2e-spa | Patch | | e2e-themes | Patch | | @evidence-dev/components | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	❌ Failed (Inspect)			Nov 5, 2024 0:58am
next-docs	❌ Failed (Inspect)			Nov 5, 2024 0:58am

netlify[bot] commented 3 weeks ago

Deploy Preview for evidence-development-workspace failed. Why did it fail? →

Name	Link
Latest commit	dc77eb4e2ccaeff06f8d3c0d592e035ab0e1f4e0
Latest deploy log	https://app.netlify.com/sites/evidence-development-workspace/deploys/672a15b79798ed00081cdf43

netlify[bot] commented 3 weeks ago

Deploy Preview for next-docs-evidence ready!

Name	Link
Latest commit	dc77eb4e2ccaeff06f8d3c0d592e035ab0e1f4e0
Latest deploy log	https://app.netlify.com/sites/next-docs-evidence/deploys/672a15b7679f6900084135ca
Deploy Preview	https://deploy-preview-2723--next-docs-evidence.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for evidence-test-env ready!

Name	Link
Latest commit	dc77eb4e2ccaeff06f8d3c0d592e035ab0e1f4e0
Latest deploy log	https://app.netlify.com/sites/evidence-test-env/deploys/672a15b7058a0d00080e96b5
Deploy Preview	https://deploy-preview-2723--evidence-test-env.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

archiewood commented 3 weeks ago

probably need to do a pnpm i to update the lockfile

and pnpm format for the linting

GriffGeorge commented 3 weeks ago

Yea, so, pnpm install seems to work but with some scary peer-dependency warnings. I pushed the new lockfile to the branch anyways. Is this ok?

Long Warning

``` $ pnpm install Scope: all 35 workspace projects WARN There are cyclic workspace dependencies: /Users/griffgeorge/src/oss/evidence/packages/lib/sdk, /Users/griffgeorge/src/oss/evidence/packages/lib/universal-sql packages/extension | WARN deprecated glob@7.2.3 packages/extension | WARN deprecated eslint@8.57.1 WARN deprecated eslint@8.45.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. packages/ui/core-components | WARN deprecated @storybook/testing-library@0.2.2 packages/ui/core-components | WARN deprecated @storybook/jest@0.2.3 WARN 27 deprecated subdependencies found: @aws-sdk/node-http-handler@3.374.0, @humanwhocodes/config-array@0.11.14, @humanwhocodes/config-array@0.13.0, @humanwhocodes/config-array@0.9.5, @humanwhocodes/object-schema@1.2.1, @humanwhocodes/object-schema@2.0.3, @npmcli/move-file@1.1.2, @npmcli/move-file@2.0.1, are-we-there-yet@2.0.0, are-we-there-yet@3.0.1, eslint@8.4.1, fstream@1.0.12, gauge@3.0.2, gauge@4.0.4, glob@7.2.0, glob@8.1.0, google-p12-pem@4.0.1, inflight@1.0.6, npmlog@5.0.1, npmlog@6.0.2, q@1.5.1, rimraf@2.7.1, rimraf@3.0.2, smartwrap@1.2.5, sourcemap-codec@1.4.8, stable@0.1.8, trim@1.0.1 Packages: +36 -36 ++++++++++++++++++++++++++++++++++++------------------------------------ Progress: resolved 2190, reused 2190, downloaded 0, added 36, done . postinstall$ run-s build:plugin-connector build:preprocess build:tailwind package:core-components build:evidence [40 lines collapsed] │ src/lib -> dist │ @sveltejs/package found the following issues while packaging your library: │ Avoid usage of `import.meta.env` in your code. It only works in apps bundled with Vite. Consider using packages like `esm-env` instead which works with all bundlers or without bundling. │ You are using SvelteKit-specific imports in your code, but you have not declared a dependency on `@sveltejs/kit` in your `package.json`. Add it to your `dependencies` or `peerDependencies`. │ @evidence-dev/core-components lint results: │ All good! │ > @ build:evidence /Users/griffgeorge/src/oss/evidence │ > pnpm --filter ./packages/evidence build │ > @evidence-dev/evidence@39.1.13 build /Users/griffgeorge/src/oss/evidence/packages/evidence │ > node scripts/build-template └─ Done in 50.4s packages/ui/core-components prepare$ svelte-kit sync └─ Done in 1.5s WARN Issues with peer dependencies found . ├─┬ @parcel/packager-ts 2.12.0 │ └─┬ @parcel/plugin 2.12.0 │ └─┬ @parcel/types 2.12.0 │ ├── ✕ missing peer @parcel/core@^2.12.0 │ ├── ✕ missing peer @parcel/core@^2.12.0 │ ├── ✕ missing peer @parcel/core@^2.12.0 │ └─┬ @parcel/cache 2.12.0 │ ├── ✕ missing peer @parcel/core@^2.12.0 │ └─┬ @parcel/fs 2.12.0 │ ├── ✕ missing peer @parcel/core@^2.12.0 │ ├── ✕ missing peer @parcel/core@^2.12.0 │ └─┬ @parcel/types 2.12.0 │ ├── ✕ missing peer @parcel/core@^2.12.0 │ └─┬ @parcel/package-manager 2.12.0 │ ├── ✕ missing peer @parcel/core@^2.12.0 │ ├── ✕ missing peer @parcel/core@^2.12.0 │ ├─┬ @parcel/fs 2.12.0 │ │ ├── ✕ missing peer @parcel/core@^2.12.0 │ │ └─┬ @parcel/workers 2.12.0 │ │ └── ✕ missing peer @parcel/core@^2.12.0 │ ├─┬ @parcel/types 2.12.0 │ │ └── ✕ missing peer @parcel/core@^2.12.0 │ └─┬ @parcel/node-resolver-core 3.3.0 │ └── ✕ missing peer @parcel/core@^2.12.0 └─┬ @parcel/transformer-typescript-types 2.12.0 └── ✕ missing peer @parcel/core@^2.12.0 Peer dependencies that should be installed: @parcel/core@">=2.12.0 <3.0.0-0" packages/lib/plugin-connector └─┬ parcel 2.12.0 └─┬ @parcel/config-default 2.12.0 └─┬ @parcel/optimizer-htmlnano 2.12.0 └─┬ htmlnano 2.1.1 └── ✕ unmet peer svgo@^3.0.2: found 2.8.0 Done in 1m 0.7s ```

GriffGeorge commented 3 weeks ago

Sorry, I don't know how to fix this. The linting issue is related to the lockfile:

pnpm install --frozen-lockfile --ignore-scripts
  shell: /usr/bin/bash -e {0}
  env:
    PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
Scope: all [3](https://github.com/evidence-dev/evidence/actions/runs/11673936381/job/32505625577?pr=2723#step:6:3)5 workspace projects
 WARN  There are cyclic workspace dependencies: /home/runner/work/evidence/evidence/packages/lib/sdk, /home/runner/work/evidence/evidence/packages/lib/universal-sql
 WARN  Ignoring not compatible lockfile at /home/runner/work/evidence/evidence/pnpm-lock.yaml
 ERR_PNPM_LOCKFILE_CONFIG_MISMATCH  Cannot proceed with the frozen installation. The current "overrides" configuration doesn't match the value found in the lockfile

Update your lockfile using "pnpm install --no-frozen-lockfile"
Error: Process completed with exit code 1.

I tried pnpm install --no-frozen-lockfile locally, and it exited cleanly, but it didn't change anything, so there's nothing to push. I also tried destroying the lockfile and recreating from scratch, same result.

archiewood commented 3 weeks ago

try deleting the lockfile and node modules and reinstalling

archiewood commented 1 week ago

need CI approval

zachstence commented 1 week ago

Hi @GriffGeorge there seems to be some sort of breaking change in snowflake-sdk causing our checks to fail because we can't connect to the DB. We're opening an issue with Snowflake to see if they can help out. Unfortunately we won't be able to merge this PR until we get that sorted.

archiewood commented 1 week ago

I just tried to reproduce this issue in https://github.com/archiewood/repro-snowflake-ocsp/tree/bumping-version and I cannot - it seems like there is some kind of breaking change, but just in the way that we are using it, not in all ways

evidence-dev / evidence