evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
4.47k stars 215 forks source link

POC DataTable Bar align #2726

Closed archiewood closed 2 weeks ago

archiewood commented 2 weeks ago

Do not merge

Idea for https://github.com/evidence-dev/evidence/issues/2725

https://deploy-preview-2726--next-docs-evidence.netlify.app/components/data-table/#bar-chart-column---right-aligned

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:17pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 3:17pm
changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 2be59ff5b91253ea2899a5a4c2933f291bef4f48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 2 weeks ago

Deploy Preview for next-docs-evidence ready!

Name Link
Latest commit 0920219b657abeb6cd12cd183454c89db0805ffa
Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/672a36481946f80008db56d9
Deploy Preview https://deploy-preview-2726--next-docs-evidence.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for evidence-test-env ready!

Name Link
Latest commit 0920219b657abeb6cd12cd183454c89db0805ffa
Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/672a364874cffd0008220f55
Deploy Preview https://deploy-preview-2726--evidence-test-env.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for evidence-development-workspace failed. Why did it fail? →

Name Link
Latest commit 0920219b657abeb6cd12cd183454c89db0805ffa
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/672a3648371bf900082e2938
archiewood commented 2 weeks ago

I worry about this implementation. I think this could be unexpected.

archiewood commented 2 weeks ago

I think a better approach might be barAlign=right