search

evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
4.47k stars 215 forks source link

Fix/loading toasts #2747

Closed mcrascal closed 2 weeks ago

mcrascal commented 2 weeks ago

Description

Removes loading toasts. There's probably a better "global" loading indicator we could give, or some loading indication at the component level, but most apps are so fast that these aren't that important.

  1. Pretty buggy: Toasts often fired but never cleared
  2. Hard to use: In practice, they were pretty hard to notice
changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 492886fd19b2b1ca8068e751880e7f78b371f48f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ------------------------- | ----- | | @evidence-dev/evidence | Patch | | my-evidence-project | Patch | | e2e-prerender | Patch | | e2e-spa | Patch | | e2e-themes | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR