search

evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in SQL and markdown
https://evidence.dev
MIT License
4.49k stars 216 forks source link

Fix double loading in accordion-wrapped charts #2759

Closed csjh closed 1 week ago

csjh commented 2 weeks ago

Description

Removes resize observation of container element in echarts.js. Still works with Fullscreen-wrapped charts. I think Fullscreen was the only other thing that depended on the resize behaviour, but would be nice if there's a way to test resize animations w/ playwright/storybook.

Checklist

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 0c538ac70fc6ae4c420fec5fd02bb2e922704af5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | --------------------------------- | ----- | | @evidence-dev/component-utilities | Patch | | my-evidence-project | Patch | | @evidence-dev/core-components | Patch | | @evidence-dev/components | Patch | | evidence-test-environment | Patch | | e2e-prerender | Patch | | e2e-spa | Patch | | e2e-themes | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR