search

evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
3.44k stars 167 forks source link

Microsoft SQL Server Connector #422

Closed mk-rocket closed 9 months ago

mk-rocket commented 1 year ago

Database Name WALRUS_DB MS SQL server

What do you use this database for? Testing and development

Are there any popular and well-maintained clients for this database? Yes

Are you interested in contributing this database connector? I'm not really a programmer, but I can definitely help with testing and reporting bugs

archiewood commented 1 year ago

Hi @mk-rocket!

This actually isn't the first request we've had for MS SQL server, and we're definitely keen to support more DBs.

Can you clarify what WALRUS_DB is? I've not heard of it before, and haven't found it after a brief internet search

(Links to online documentation especially helpful!)

mk-rocket commented 1 year ago

hi @archiewood WALRUS_DB is just a test DB name - I wasn't sure what to put on that field so I just placed a random name. I am just adding a request for MS SQL Server and I am glad that its on your list already. Thanks!

archiewood commented 1 year ago

Ah that makes sense - we meant for people to fill in eg "Microsoft SQL Server" there, but now I think about it, this would almost always be in the title of the issue!

@hughess is it worth editing the issue template to make this a bit clearer? Perhaps we should just remove the Database Name field?

hughess commented 1 year ago

@archiewood I agree - I've just removed it from the template!

mk-rocket commented 1 year ago

Is MSSQL still on your roadmap?

hughess commented 1 year ago

@mk-rocket yes it is! Hoping to get to it fairly soon - and also definitely open to contributions for this.

A few questions to help us with planning:

archiewood commented 1 year ago

@mk-rocket @majkinetor @aakinlalu We now have a PR for MS SQL server. Would you be open to testing it?

mk-rocket commented 1 year ago

That is great news - unfortunately, I am about to go on vacation and will have limited internet. I can touch base again in a week if the testing window is still open.

mk-rocket commented 1 year ago

Here are my replies to your questions;

What type of auth do you use to access your MSSQL?

What types of auth do you think we should support in an MSSQL connector?

Once it's in development, would you be willing to help with testing?

aakinlalu commented 1 year ago

I can do it. Are we just testing the connector for MSSQL?

csjh commented 1 year ago

I can do it. Are we just testing the connector for MSSQL?

Yeah, check out #879 for the PR. Would be very very helpful if you could try out any/all of the Azure auth methods.