evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
3.44k stars 167 forks source link

Improving Visual Hierarchy #481

Closed archiewood closed 1 year ago

archiewood commented 1 year ago

Why?

What?

This contains some reasonably major stylistic updates to the default styling of Evidence projects:

Questions

Headings

Before:

CleanShot 2022-11-29 at 10 18 19@2x

After:

CleanShot 2022-11-29 at 10 19 13@2x

Lists:

Before:

image

After:

image
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: cf923c2254e99382b4ecf7e6de945b53aff6cdc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ------------------------- | ----- | | @evidence-dev/components | Patch | | @evidence-dev/evidence | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
evidence-development-workspace ❌ Failed (Inspect) Jan 3, 2023 at 11:01PM (UTC)
evidence-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 11:01PM (UTC)
hughess commented 1 year ago

Thoughts on the changes in this PR / answers to your questions:

I took a look at our current headings in comparison to our visual elements (screenshots below) and have these thoughts:

Charts

CleanShot 2022-12-19 at 10 58 05@2x

Tables

CleanShot 2022-12-19 at 11 07 51@2x

Big Values

CleanShot 2022-12-19 at 10 57 39@2x

Text

CleanShot 2022-12-19 at 10 58 17@2x

Blockquotes

CleanShot 2022-12-19 at 10 58 25@2x
hughess commented 1 year ago

I don't think this makes sense to add now, but in the future if we need more options to visually separate elements on a page, we can use colours to create distinct sections of content. For example:

CleanShot 2022-12-19 at 11 57 25@2x
hughess commented 1 year ago

Here are some comparisons after changing the BigValue thickness and making the base font colour darker:

CleanShot 2022-12-19 at 12 07 15@2x CleanShot 2022-12-19 at 12 08 00@2x CleanShot 2022-12-19 at 12 08 13@2x
archiewood commented 1 year ago

I dig the BigValue thickness changes I think they look more elegant. They are still big enough to grab they eye I think

Re the font colours for the headings. I suspect keeping the larger headings at slightly lighter grey is the right call. The Flawless Typography Checklist has a good piece on this:

image

It's subtle but effective:

image
archiewood commented 1 year ago

Changes

@mcrascal would be great to get your blessing on this as I know you did a lot of the original thinking!

Before

image

After

image

All the headers

image
mcrascal commented 1 year ago

I really like it, definitely has my blessing. Thanks @thomsebastin also!

The only issue I have is with the italics in the H3s. I know the H3s are really tricky, but I don't dig italics on that UI font.

I'd propose taking off the italics and taking the size down by 0.1em. After that the H3 is still very heavy relative to the serif body and smaller headers, but it's also a lot smaller than the H2s.

I'll open a PR with the change -- your call if you want to include it.

CleanShot 2023-01-03 at 16 43 55@2x
archiewood commented 1 year ago

That looks great. Feel free to just commit to this branch, or I can rather than opening a new PR!

mcrascal commented 1 year ago

PR against this branch is already open! #552

archiewood commented 1 year ago

Seems fine to merge. Failing check is because we have changed the build command on evidence-development-workspace