Closed archiewood closed 1 year ago
Latest commit: cf923c2254e99382b4ecf7e6de945b53aff6cdc6
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
evidence-development-workspace | ❌ Failed (Inspect) | Jan 3, 2023 at 11:01PM (UTC) | ||
evidence-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Jan 3, 2023 at 11:01PM (UTC) |
Thoughts on the changes in this PR / answers to your questions:
I took a look at our current headings in comparison to our visual elements (screenshots below) and have these thoughts:
BigValue
contents makes it hard for headers to take visual priority over them
font-weight: 500
) color: var(--grey-999)
) I don't think this makes sense to add now, but in the future if we need more options to visually separate elements on a page, we can use colours to create distinct sections of content. For example:
Here are some comparisons after changing the BigValue thickness and making the base font colour darker:
I dig the BigValue thickness changes I think they look more elegant. They are still big enough to grab they eye I think
Re the font colours for the headings. I suspect keeping the larger headings at slightly lighter grey is the right call. The Flawless Typography Checklist has a good piece on this:
It's subtle but effective:
@mcrascal would be great to get your blessing on this as I know you did a lot of the original thinking!
I really like it, definitely has my blessing. Thanks @thomsebastin also!
The only issue I have is with the italics in the H3s. I know the H3s are really tricky, but I don't dig italics on that UI font.
I'd propose taking off the italics and taking the size down by 0.1em. After that the H3 is still very heavy relative to the serif body and smaller headers, but it's also a lot smaller than the H2s.
I'll open a PR with the change -- your call if you want to include it.
That looks great. Feel free to just commit to this branch, or I can rather than opening a new PR!
PR against this branch is already open! #552
Seems fine to merge. Failing check is because we have changed the build command on evidence-development-workspace
Why?
<p>
text size wise.What?
This contains some reasonably major stylistic updates to the default styling of Evidence projects:
Questions
Headings
Before:
After:
Lists:
Before:
After: