search

evidence-dev / evidence

Business intelligence as code: build fast, interactive data visualizations in pure SQL and markdown
https://evidence.dev
MIT License
3.44k stars 167 forks source link

Additional UI components #817

Closed nidhi-kala closed 10 months ago

nidhi-kala commented 1 year ago

Addressing #496

Adding the following components:

Checklist

Accordion:

Screenshot 2023-04-28 at 00 04 32

Anchor Button:

Screenshot 2023-04-28 at 00 05 25

Modal:

Screenshot 2023-04-28 at 00 03 01
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 77c9f5afabcd9445eab537a49a905847c3bbbd5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ------------------------- | ----- | | @evidence-dev/preprocess | Minor | | @evidence-dev/components | Minor | | @evidence-dev/evidence | Patch | | evidence-test-environment | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evidence-development-workspace ❌ Failed (Inspect) Jul 12, 2023 3:29am
evidence-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 3:29am
vercel[bot] commented 1 year ago

@nidhi-kala is attempting to deploy a commit to the Evidence Dev Team on Vercel.

A member of the Team first needs to authorize it.

hughess commented 1 year ago

Hey @nidhi-kala, I checked into the error with the vercel deploy preview and it looks you've got imports in two places - once in preprocess and again in the markdown files. Should work once you remove the markdown imports!

nidhi-kala commented 1 year ago

Hey @nidhi-kala, I checked into the error with the vercel deploy preview and it looks you've got imports in two places - once in preprocess and again in the markdown files. Should work once you remove the markdown imports!

Oh yeah! I was actually just working on this. I will update it. Thanks! :)

nidhi-kala commented 1 year ago

@archiewood Thank you for the early feedback and pointing me to the tabs component :) Initially I wanted to make sure basic accordion was working and then iterate on it to have a nested component. I've updated the PR now. Let me know if it needs any changes!

I'll add footnotes component tomorrow :-D

netlify[bot] commented 1 year ago

Deploy Preview for evidence-development-workspace ready!

Name Link
Latest commit 77c9f5afabcd9445eab537a49a905847c3bbbd5f
Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/64ae1deb7c95990008efadb3
Deploy Preview https://deploy-preview-817--evidence-development-workspace.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

archiewood commented 1 year ago

Ugh somehome I didnt hit send on a few edits I suggested, sorry

Hoping I remember them all!

Accordion

The rounding of the corners slightly cuts off the borders for me

Anchor button

Looks great

Modal

Can we remove the border round the "X" button to close

Docs

Let's add some. For Accordion and Modal, I think it would be helpful to add a couple of different examples (with different props). The Maps component is a great example

hughess commented 10 months ago

Took a spin through these and they're looking great!

A few things I noticed:

Accordion

Modal

Anchor Button

archiewood commented 10 months ago

@jdimmerman this is pretty close but we have a few outstanding tweaks

archiewood commented 10 months ago

Addressed all the above feedback except the clickOutside which for some reason eludes me

archiewood commented 10 months ago

Thanks @nidhi-kala!