Open elenasamuylova opened 1 year ago
Hi, to address this, would it be possible to adjust the following classes:
and any other inherited class such as ColumnValueRangeMetric from metrics\data_quality\column_value_list_metric.py
Adjust them to accept Timestamp types (right and left) and not only Numeric.
The column.between() pandas method (that is used in ColumnValueRangeMetric
) can be used with Timestamps.
What do you think?
Hi @AntonisCSt , This sounds like a good approach!
I'm very sorry for the late reply. The things is that we worked on MetricResult
refactoring and we didn't want to update any metric before we finish. We finally transitioned MetricResult
classes from DataClass to Pydantic in the latest release, and now ready to update Metrics.
Would you consider making a contribution?
Hi @emeli-dral, Thank you for the update! I would be definitely happy to make a contribution.
So now with the new approach are there any specific guidelines or steps I should follow to get started? If not, I can move on and update the TestValueRange and ColumnValueRangeMetric classes to accept Timestamp types.
Test Group: Data Quality
Feature request: to add the ability to test that values in a DateTime column are within a specific range.
Source: Discord conversation https://discord.com/channels/815991896916361276/815992391076806657/threads/1044973406929571860