evil-mad / EggBot

Software for The Original EggBot
GNU General Public License v3.0
287 stars 140 forks source link

Update servo timeout behavior #126

Closed oskay closed 4 years ago

oskay commented 4 years ago

Following up on #103, it looks like the servo timeout was not actually implemented according to the original plan there-- which was that the "Power to the servo will be automatically switched off after some period of time elapsed since the last action moving it."

What is actually implemented is that "Power to the servo is be automatically switched off after some period of time elapsed since the last action moving it or the stepper motors."

This implementation does not allow the servo to be off while moving the steppers.

The documentation appears to correctly describe the present behavior

I suspect that there's no harm in making a change to the SR command such that it waits only until after stepper movements, since the computer can always turn it on for longer.

EmbeddedMan commented 4 years ago

Whoops. OK, on it.

On Fri, Nov 29, 2019 at 9:37 PM Windell Oskay notifications@github.com wrote:

Following up on #103 https://github.com/evil-mad/EggBot/issues/103, it looks like the servo timeout was not actually implemented according to the original plan there-- which was that the "Power to the servo will be automatically switched off after some period of time elapsed since the last action moving it."

What is actually implemented is that "Power to the servo is be automatically switched off after some period of time elapsed since the last action moving it or the stepper motors."

This implementation does not allow the servo to be off while moving the steppers.

The documentation http://evil-mad.github.io/EggBot/ebb.html#SR appears to correctly describe the present behavior

I suspect that there's no harm in making a change to the SR command such that it waits only until after stepper movements, since the computer can always turn it on for longer.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/evil-mad/EggBot/issues/126?email_source=notifications&email_token=AADN4CETJVOBHUML7G35SJ3QWHNYXA5CNFSM4JTEX5DKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H47GSTA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADN4CEGMRNORDCJZLQMRN3QWHNYXANCNFSM4JTEX5DA .

EmbeddedMan commented 4 years ago

New version 2.6.5 created with this issue fixed. Windows updater created. Docs updated. Pushed. Please test and merge if it's working as intended now.

EmbeddedMan commented 4 years ago

@oskay If you've had a chance to test this new version, please merge the Branch_Issue126 in.

oskay commented 4 years ago

https://github.com/evil-mad/EggBot/pull/129