evil-mad / axidraw

Software for the AxiDraw drawing machine
GNU General Public License v2.0
432 stars 131 forks source link

axidrawinternal not listed in dependencies #98

Closed x37v closed 3 years ago

x37v commented 3 years ago

The README says

Manual install (Linux):

Install (along with the dependencies listed below) as you would any other Inkscape extension.

Dependencies:

    plotink helper routines for Inkscape extensions.
    eggbot_hatch.py from the EggBot extensions for Inkscape.
    Pyserial. (Note that an older version, 2.7, must be used on Windows when using Inkscape 0.91 or older.)

When I put all that and the contents of inkscape driver into ~/.config/inkscape/extensions/ and then run the extension in inkscape I get an error

Traceback (most recent call last):
  File "axidraw_control.py", line 28, in <module>
    from axidrawinternal import axidraw   # https://github.com/evil-mad/axidraw
ModuleNotFoundError: No module named 'axidrawinternal'

Where does this come from? I see it in the release but not git. I guess I see something about it in the cli requirements.txt being on gitlab, is this not part of the open source shared code base?

oskay commented 3 years ago

Yes, the readme is out of date.

If you would like to install a version that works in Inkscape, please use our release for Inkscape.

The "active" parts for the 2.7.0 release are in this repository. There is some packaging and wrappers (including one that labels the main contents of this repository as "axidrawinternal") that is not maintained here. Those parts are included in the main download. Everything in the download (including the wrapper) is part of the open source release.

x37v commented 3 years ago

Yes, the readme is out of date.

If you would like to install a version that works in Inkscape, please use our release for Inkscape.

The "active" parts for the 2.7.0 release are in this repository. There is some packaging and wrappers (including one that labels the main contents of this repository as "axidrawinternal") that is not maintained here. Those parts are included in the main download. Everything in the download (including the wrapper) is part of the open source release.

Ahh, okay thanks @oskay

akx commented 2 years ago

There is some packaging and wrappers (including one that labels the main contents of this repository as "axidrawinternal") that is not maintained here.

Hmm – it looks like e.g. eggbot_hatch.py https://github.com/evil-mad/axidraw/blob/1b84dda355bc3bba8e4935e1fe6ea84a223e59df/inkscape%20driver/axidraw_hatch.inx#L6 comes from that repo..?

oskay commented 2 years ago

Is there a question?

akx commented 2 years ago

Sort of. It implies that this repo isn't fully usable on its own without the axidrawinternal bits.

oskay commented 2 years ago

The install bundle includes things from quite a few repositories. For example, eggbot_hatch.py comes from https://github.com/evil-mad/EggBot/blob/Inkscape_v1/inkscape_driver/eggbot_hatch.py

We do not have support for installing directly from the repository.

akx commented 2 years ago

Right - that seems a little complex, but alright. I presume the build process for the install bundle isn't open source?

oskay commented 2 years ago

All of the files in the open source release are open source. None of the installers, nor the scripts to build them, is open source.

akx commented 2 years ago

@oskay Thanks, that clarifies things. Happy holidays!