search

evil-mad / robopaint

The software for your friendly painting robot kit!
127 stars 34 forks source link

Subpath refill mode additions #211

Closed gwygonik closed 9 years ago

gwygonik commented 9 years ago

These changes allow for re-inking after each subpath of a drawing.

techninja commented 9 years ago

WOW! Just.. Wow.

Absolutely beautiful use of the tools available, using translatable strings, clean, broken-up commits, clean diff, clean logic added that mirrors that around it.

The only issues here are minor and pedantic indentation/comment related. I'd say this is a total slam dunk!

Now if only we had a better way to select these options visually before painting... That is likely another task at a later time.

Thank you for your hard work!

Somewhat unrelated heads up: To avoid any upstream issues in the future, be sure to make a branch in your fork for any new features you've got planned. If you trip up your master branch, it can be hard to fix, but if you mess up a branch, if can just be pruned off :)

gwygonik commented 9 years ago

Thanks! You made an easy-to-understand model and framework, so it was pretty straightforward to get the stuff in. I hope it works for folks :-)