evil-mad / robopaint

The software for your friendly painting robot kit!
127 stars 34 forks source link

Settings window: Modes toggle buttons are hard to actuate #243

Closed oskay closed 8 years ago

oskay commented 8 years ago

Tested on Mac. Some of the mode buttons are very challenging to press-- they seem only intermittently responsive.

techninja commented 8 years ago

The way they're made likely has their two clickable elements moved around a bit. I'll verify and attempt a fix.

techninja commented 8 years ago

Hmmmmmmm clicktest

Not quite seeing the problem. :confused:

This was captured with "LICECap" (terrible name, great app), with click animation on. See if you cant reproduce and record it and I'll see if i can tell what's going on.

oskay commented 8 years ago

The problem is only in the Modes panel.

oskay commented 8 years ago

OK, yes, LICECap is a great app.

robopaintmodes

techninja commented 8 years ago

Aha! That is actually on purpose! Core modes are not switchable. Notice they're somewhat faded to denote their disabled property. The idea being that core modes represent something that is expected and not directly toggle-able. I've been waffling on what to actually do for this, and tried it with having everything be adjustable, but you still kind of need them, so I just went with "disabled == core".. course it doesn't quite make sense for spiral... Eh. It's all a test.

oskay commented 8 years ago

Ugh. You do realize that this means that they can't be turned on either, right?

robopaintmodes2

oskay commented 8 years ago

Related issue: The "Reset" button turns all of the modes off. (This is probably not the intended effect.)

Once the modes are off, the core modes cannot be enabled, except by quitting and restarting RoboPaint.

oskay commented 8 years ago

Also: Is there any reason that the core modes must be left visible? I can imagine situations where one might want to only allow enable (for example) the remote print mode.

techninja commented 8 years ago

Aha!! THAT is the real bug there! Otherwise you wouldn't be able to disable them in the first place. What do you recommend (besides fixing the reset all mode disabled bug)?

techninja commented 8 years ago

Yea, makes sense. We don't technically need the disabled locking. I'll just remove that and a user could choose to only have remote paint visible.. though clicking on a quick load image will still load the print mode

oskay commented 8 years ago

Yes, disabling the modes is how I came across this. :)

Allowing you to disable any should be a great solution.... and auto-loading a mode like that when you ask for it sounds like a reasonable side effect.

techninja commented 8 years ago

bug-vs-feature