evil-mad / wcb-ink

WaterColorBot extensions for Inkscape
22 stars 8 forks source link

hatch freezes inkscape with empty document #31

Open polycopter opened 10 years ago

polycopter commented 10 years ago

seems like a timeout or test for serial connection might be missing?

oskay commented 10 years ago

The WCB Hatch Fill extension does not attempt to communicate with the serial port in any sense. It is purely a graphical effect, and does not have any code that can create or detect a serial connection.

If it is crashing for you, I would be very surprised (and utterly stumped) if there is any correlation to whether the WCB is plugged in.

Can you please say:

polycopter commented 10 years ago

my bad. I think the issue was not the bot being unattached, it was the document being empty. some kind of "sanity check" may be missing. obviously not a high priority issue, why would anyone try to hatch fill a blank document? unless, like me, they just want to see what happens. I am running Ubuntu 13.?? (I forget, and don't know how to check, but I think it's a higher # than 10 in the last 2 digits), Inkscape Help->About reports 0.48. Steps to reproduce: launch Inkscape (get a default blank document), select Extensions->WatercolorBot->hatch fill... wait a little while (nothing happens, apparently)... then click Cancel; Inkscape is frozen. It may be frozen already, before you click Cancel, but I haven't waited a long time to see if it finishes, or times out, or something, and becomes responsive again, before clicking Cancel. I have waited a long time after clicking Cancel, though. Process monitor shows Python taking up a steady 12% of the CPU.