Closed SafeteeWoW closed 6 years ago
I am in raid. cant provide detail atm
Anyway related to the recent changes? I'm just about to push an hotfix to the pass button stuff - would appreciate more feedback when possible.
Several people are more likely to be affected by it.
I'll provide feedback after each boss
Only several people are affected. Their version is 2.7.1 or 2.7.2. They can see loot frame some times, sometimes cant
I am unlikely to provide any SV until raid ends in 2h.
Not sure if it is a Blizzard bug. Everytime I start a session. Those player receives system message "cannot find player "Unknown-Servername" (Actually it's Chinese message)
That points to any check of the ML/name - I just don't see any changes to that in the last two updates.
Probably we should check if the ML name is _G.UNKNOWNOBJECT I think probably "Unknown" is localized name? Let's check both.
The check in NewMLCheck
should probably check for the global string - but even then, the ML name should have been gathered before it's used.
Are you playing with english locale? If not, is it "Unknown" or is it translated? (I never thought about the latter).
I am using English, but my raiders use enUS, zhCN, zhTW.
So "Unknown" or translated? Need to know if I can include _G.UNKNOWNOBJECT instead.
Their system chat message shows "未知目标”, which should be _G.UNKNOWNOBJECT
Ok, I think this is the problem because I can solve the issue by switching ML and then switching back.
Let's include both "Unknown" and _G.UNKNOWNOBJECT
Dont quote _G.UNKNOWNOBJECT
I'm wondering why this hasn't happened before though.. Pushing a new version now.
Good point. It's too late at night for me 💤
Blizzard code confirms "Unknown" is localized.
-- FrameXML/RaidUI.lua:746
local unitName = UnitName(unit);
if ( unitName and unitName ~= UNKNOWNOBJECT ) then
I am not sure why you use strfind though. Should just use ~=
Because the name also contains realmname, i.e. "Unknown-Realm".
Just let you know. Happens randomly to random people