evil-morfar / RCLootCouncil2

RCLootCouncil - addon for World of Warcraft
https://rclootcouncil.com
GNU Lesser General Public License v3.0
19 stars 29 forks source link

Some people cant see the loot frame. #131

Closed SafeteeWoW closed 6 years ago

SafeteeWoW commented 6 years ago

Just let you know. Happens randomly to random people

SafeteeWoW commented 6 years ago

I am in raid. cant provide detail atm

evil-morfar commented 6 years ago

Anyway related to the recent changes? I'm just about to push an hotfix to the pass button stuff - would appreciate more feedback when possible.

SafeteeWoW commented 6 years ago

Several people are more likely to be affected by it.

SafeteeWoW commented 6 years ago

I'll provide feedback after each boss

SafeteeWoW commented 6 years ago

Only several people are affected. Their version is 2.7.1 or 2.7.2. They can see loot frame some times, sometimes cant

SafeteeWoW commented 6 years ago

I am unlikely to provide any SV until raid ends in 2h.

SafeteeWoW commented 6 years ago

Not sure if it is a Blizzard bug. Everytime I start a session. Those player receives system message "cannot find player "Unknown-Servername" (Actually it's Chinese message)

evil-morfar commented 6 years ago

That points to any check of the ML/name - I just don't see any changes to that in the last two updates.

SafeteeWoW commented 6 years ago

Probably we should check if the ML name is _G.UNKNOWNOBJECT I think probably "Unknown" is localized name? Let's check both.

evil-morfar commented 6 years ago

The check in NewMLCheck should probably check for the global string - but even then, the ML name should have been gathered before it's used.

evil-morfar commented 6 years ago

Are you playing with english locale? If not, is it "Unknown" or is it translated? (I never thought about the latter).

SafeteeWoW commented 6 years ago

I am using English, but my raiders use enUS, zhCN, zhTW.

evil-morfar commented 6 years ago

So "Unknown" or translated? Need to know if I can include _G.UNKNOWNOBJECT instead.

SafeteeWoW commented 6 years ago

Their system chat message shows "未知目标”, which should be _G.UNKNOWNOBJECT

SafeteeWoW commented 6 years ago

Ok, I think this is the problem because I can solve the issue by switching ML and then switching back.

SafeteeWoW commented 6 years ago

Let's include both "Unknown" and _G.UNKNOWNOBJECT

SafeteeWoW commented 6 years ago

Dont quote _G.UNKNOWNOBJECT

evil-morfar commented 6 years ago

I'm wondering why this hasn't happened before though.. Pushing a new version now.

evil-morfar commented 6 years ago

Good point. It's too late at night for me 💤

SafeteeWoW commented 6 years ago

Blizzard code confirms "Unknown" is localized.

-- FrameXML/RaidUI.lua:746
local unitName = UnitName(unit);
if ( unitName and unitName ~= UNKNOWNOBJECT ) then

I am not sure why you use strfind though. Should just use ~=

evil-morfar commented 6 years ago

Because the name also contains realmname, i.e. "Unknown-Realm".